fix off by one error for slice accounting - #10406
Merged
Jefffrey merged 2 commits intoJul 23, 2026
Merged
Conversation
Jefffrey
approved these changes
Jul 23, 2026
Contributor
|
thanks @Rich-T-kid, nice catch |
Contributor
Author
|
thx @Jefffrey 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
get_slice_memory_sizeis used to estimate how much memory a slice of an ArrayData actually occupies. For variable-width types (Utf8, Binary, List, etc.), the offset buffer stores len+1 boundaries, one per element plus a final entry marking the end of the last element. The old code calculatedlen * byte_width, missing that final boundary and consistently under-reporting the size of any array using an offset buffer.What changes are included in this PR?
the FixedWidth buffer size is now calculated as (len + 1) * byte_width instead of len * byte_width.
Are these changes tested?
Yes I added two test for string arrays and binary arrays. existing test still pass
Are there any user-facing changes?
users will have more accurate memory accounting